-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EW-1061 TBA #5330
Draft
psachmann
wants to merge
141
commits into
main
Choose a base branch
from
EW-1061
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
EW-1061 TBA #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
SevenWaysDP
requested changes
Nov 12, 2024
Comment on lines
1
to
20
import { Inject, Injectable, UnauthorizedException } from '@nestjs/common'; | ||
import { ConfigService } from '@nestjs/config'; | ||
import { REQUEST } from '@nestjs/core'; | ||
import { extractJwtFromHeader } from '@shared/common'; | ||
import { Request } from 'express'; | ||
import { FilesStorageClientConfig } from './files-storage-client.config'; | ||
import { Configuration, FileApiFactory, FileApiInterface } from './generated'; | ||
|
||
@Injectable() | ||
export class FilesStorageClientFactory { | ||
constructor( | ||
@Inject(REQUEST) private readonly request: Request, | ||
private readonly configService: ConfigService<FilesStorageClientConfig, true> | ||
) {} | ||
|
||
/** | ||
* Creates a new file client and configures it with the provided token or the token from the request. | ||
* @param token can be provided to override the token from the request. | ||
* @returns fully configured file client. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's talk about this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBA
Links to Tickets or other pull requests
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.